RFR (XXS): 8025849: Redundant "pid" in VM log file name (e.g. hotspot_pidpid12345.log)

[Vladimir Ivanov]

Azeem,

No, I haven't tested it on Windows.

Expansion takes place in make_log_name_internal (ostream.cpp):
   if (pid_pos >= 0) {
     jio_snprintf(pid_text, sizeof(pid_text), "pid%u", pid);
     buffer_length += strlen(pid_text);
   }

So, the behavior is consistent across supported platforms.

Best regards,
Vladimir Ivanov

On 10/4/13 1:42 AM, Azeem Jiva wrote:
> Did you test this on different OSes?  Just to make sure that %p does
> return 'pid#' rather than just '#'.  Windows would be a good one to test
> at the minimum.  Otherwise it's fine (not a real reviewer).
>
>
> --
> Azeem Jiva
> @javawithjiva
>
> On Oct 3, 2013, at 2:30 PM, Vladimir Ivanov
> <vladimir.x.ivanov at oracle.com <mailto:vladimir.x.ivanov at oracle.com>> wrote:
>
>> http://cr.openjdk.java.net/~vlivanov/8025849/webrev.00
>> 2 lines changed: 0 ins; 0 del; 2 mod
>>
>> make_log_name function does the following expansion: %p => pid{pid}.
>> Fix VM log file name, removing unnecessary "pid" from the pattern.
>>
>> FYI, I filed JDK-8025905 to track discrepancy between "%p" in LogFile
>> & ErrorFile.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8025905
>