RFR(XS) JDK-8013830: [parfait] Uninitialised pointer 'Reachblock' may be used as argument

Roland Westrelin roland.westrelin at oracle.com
Mon Oct 7 09:18:15 PDT 2013


Hi Niclas,

> The uninitialized pointer 'Reachblock' can be replaced with NULL at the call since the node we are re-materializing will not have any live range input (because of contains_no_live_range_input(def)).
> 
> WEBREV: http://cr.openjdk.java.net/~adlertz/JDK-8013830/webrev00/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8013830

Can you give more details? Which test in PhaseChaitin::split_Rematerialize() fails/succeeds so that we don't reach 

 378         assert(Reachblock != NULL, "Reachblock must be non-NULL");
 379         Node *rdef = Reachblock[lrg2reach[lidx]];

when contains_no_live_range_input(def)is true?

Roland.


More information about the hotspot-compiler-dev mailing list