RFR (XXS): 8007923: Tests on references fails
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Oct 8 13:56:53 PDT 2013
Good.
Vladimir
On 10/8/13 1:54 PM, Christian Thalinger wrote:
>
> On Oct 8, 2013, at 12:35 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>
>> Please, fix assert in ciKlass::is_subtype_of() too.
>
> Yeah, good point. I've also removed the wrong comment in ciKlass::is_subclass_of:
>
> http://cr.openjdk.java.net/~twisti/8007923/webrev.01/
>
>>
>> thanks,
>> Vladimir
>>
>> On 10/8/13 12:08 PM, Christian Thalinger wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8007923
>>> http://cr.openjdk.java.net/~twisti/8007923/webrev.00/
>>>
>>> 8007923: Tests on references fails
>>> Reviewed-by:
>>>
>>> Escape analysis treats java.lang.ref.Reference as any other object and tries to scalarize it. In this particular fail one Reference does not escape but the other one does. When it comes to a pointer equality check the pointer comparison optimization falsely assumes that the non-escaped Reference cannot escape but in fact it can when the garbage collector enqueues the Reference in the queue.
>>>
>>> After more internal discussion we decided to exclude java.lang.ref.Reference from being scalarized since they can escape globally any time.
>>>
>
More information about the hotspot-compiler-dev
mailing list