RFR (S): 8005173: assert(false) failed: DEBUG MESSAGE: exception oop must be empty (macroAssembler_x86.cpp:625)

[Vladimir Kozlov]

Looks good.

Thanks,
Vadimir

On 10/10/13 5:48 PM, Christian Thalinger wrote:
> https://bugs.openjdk.java.net/browse/JDK-8005173
> http://cr.openjdk.java.net/~twisti/8005173/webrev.00/
>
> 8005173: assert(false) failed: DEBUG MESSAGE: exception oop must be empty (macroAssembler_x86.cpp:625)
> Reviewed-by:
>
> The problem is that we don't clean the current exception oop and pc in OptoRuntime::handle_exception_C_helper before calling out to SharedRuntime::compute_compiled_exc_handler which call load classes and thus execute Java code.
>
> The corresponding code for C1 in exception_handler_for_pc_helper does that.
>
> Since the assert we are hitting in Runtime1::generate_handle_exception only exists on x86 we should also add it on the other platforms (or SPARC at least).
>