RFR(S) : 8026124 : JSR-292 bug: java.nio.file.Path.toString cores dump

[Vladimir Kozlov]

On 10/12/13 9:55 AM, Christian Thalinger wrote:
>
> On Oct 12, 2013, at 8:35 AM, David Chase <david.r.chase at oracle.com> wrote:
>
>> New webrev: http://cr.openjdk.java.net/~drchase/8026124/webrev.01/
>>
>> Fixed "     ->     "

You missed one in condition.

>> Made assertions fail more informatively.
>
> Nice.  Only a suggestion but since the debug code spans already 8 lines maybe ditch DEBUG_ONLY and use an #ifdef ASSERT around all that stuff.  You don't have to do it.

+1 for #ifdef ASSERT

You don't need @compile line in the test:

* @compile CreatesInterfaceDotEqualsCallInfo.java

Thanks,
Vladimir

>
> Looks good.
>
>> Tested failure printing (inserted "false && ", recompiled and ran).
>> Added test (uses Javascript from bug report).
>>
>> David
>>
>>
>> On 2013-10-12, at 10:03 AM, David Chase <david.r.chase at oracle.com> wrote:
>>
>>>
>>> On 2013-10-12, at 3:12 AM, John Rose <john.r.rose at oracle.com> wrote:
>>>>
>>>> Your best bet might be asm.  (I tried a few variations on the theme of TestIntfc::toString, including some emacs-ing of class files, but no luck.)  Might I recommend a reusable BogoLoader in test/java/lang/invoke/?
>>>
>>> Except that this is in the hotspot hierarchy, so that's the wrong tests.
>>>
>>> The other problem I have with this is that I don't entirely understand the packaging requirements for test classes shared by several tests in subdirectories -- I have from time to time experienced test harness failures of the form
>>> "java.lang.SecurityException: Prohibited package name: java.util.stream"
>>> and until I understand the cause, I'm reluctant to stray from what has worked in the past,
>>> which is a top-level collection of test classes in a subdirectory.
>>>
>>> David
>>>
>>
>