RFR(S) : 8026124 : JSR-292 bug: java.nio.file.Path.toString cores dump

Christian Thalinger christian.thalinger at oracle.com
Mon Oct 14 14:15:04 PDT 2013


But you have indent:

+    #ifdef ASSERT
+    // Ensure that this is really the case.

The recommended way is:

+#ifdef ASSERT
+    // Ensure that this is really the case.

On Oct 14, 2013, at 11:47 AM, David Chase <david.r.chase at oracle.com> wrote:

> What is the recommended indent of the #ifdef?  I did look around, and I think the first example I found did not indent, so I copied that.
> 
> David
> 
> On 2013-10-14, at 2:28 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> Looks good (except the indent of the #ifdef).
>> 
>> On Oct 12, 2013, at 2:28 PM, David Chase <david.r.chase at oracle.com> wrote:
>> 
>>> Additional fixes applied:
>>> 
>>> http://cr.openjdk.java.net/~drchase/8026124/webrev.02/
>>> 
>>> On 2013-10-12, at 1:40 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 



More information about the hotspot-compiler-dev mailing list