RFR (S): 8026478: -XX:+VerifyAdapterSharing is broken

[Christian Thalinger]

The change looks good.  Did you remove saving the signature because it wasn't used anyway?

On an unrelated note but I hate these field names:

  static BufferBlob* _code1;                               // code buffer for initial routines
  static BufferBlob* _code2;                               // code buffer for all other routines

Could you file an RFE to rename these two?

On Oct 15, 2013, at 4:14 AM, Albert Noll <albert.noll at oracle.com> wrote:

> Hi,
> 
> could I have reviews for this small patch?
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8026478
> webrev: http://cr.openjdk.java.net/~anoll/8026478/webrev.00/
> 
> Problem: This flag is broken. The reason is that adapters (gen_i2c_adapter()) that are generated during VM startup do not include the range for StubRoutines::code2() if -XX:+VerifyAdapterCalls is specified. StubRoutines::code2() is only allocated later during startup; consequently, code2() is NULL. As a result, the size of the generated adapter as well as the code itself does not mactch.
> 
> Solution: Defer check (VerifyAdapterSharing) until VM is initialzied. Note that this patch also fixes potential issues with -XX:+VerifyAdapterCalls, which is a dignostic flag. The patch also removes some unused field of VerifyAdapterSharing.
> 
> 
> Many thanks in advance,
> Albert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20131015/361b6bca/attachment-0001.html