RFR(XS): 8026708: guarantee(codelet_size > 0 && (size_t)codelet_size > 2*K) failed: not enough space for interpreter generation

[Vladimir Kozlov]

Good.

Thanks,
Vladimir

On 10/16/13 1:06 PM, Albert Noll wrote:
> Hi Vladimir,
>
> thanks for the review. I agree, this gives us more air.
> Here is the new webrev:
> http://cr.openjdk.java.net/~anoll/8026708/webrev.01/
> <http://cr.openjdk.java.net/%7Eanoll/8026708/webrev.01/>
>
> Best,
> Albert
>
> P.S.: I had the wrong header to the mail. The bug id is actually 8026708.
>
>
>
> On 16.10.2013 21:28, Vladimir Kozlov wrote:
>> I think we should increase it more for future otherwise you will have
>> to always catch up with interpreter changes.
>>
>> Increase it to 256 * 1024 and 224 * 1024
>>
>> Vladimir
>>
>> On 10/16/13 12:22 PM, Albert Noll wrote:
>>> Hi,
>>>
>>> could I have a review for this patch?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8026708
>>> webrev: http://cr.openjdk.java.net/~anoll/8026708/webrev.00/
>>> <http://cr.openjdk.java.net/%7Eanoll/8026708/webrev.00/>
>>>
>>> Problem: Not enough room for interpreter. My last patch did not solve
>>> the problem for solaris-amd64.
>>>                 A local build (solaris-amd64) of the most recent
>>> hotspot-comp version requires a template interpreter
>>>                 size of 211K (obtained with -XX:+PrintInterpreter).
>>> There have been some modifications to the template
>>>                 interpreter in the last couple of weeks which might have
>>> triggered this error.
>>>
>>> Solution: Increase interpreter size by 8k (32-bit and 64-bit).
>>>
>>> Testing: Failing test case in solaris-amd64
>>>
>>>
>>> Many thanks in advance,
>>> Albert
>