8027445: SIGSEGV at TestFloatingDecimal.testAppendToDouble()I

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Oct 31 08:57:32 PDT 2013


On 10/31/13 8:47 AM, Roland Westrelin wrote:
>>>> And it can happen in 32 bit mode since SPARC's registers are 64-bit, so don't put it under #ifdef LP64.
>>>
>>> In 32bit mode, it can happen that the upper half of a register is non null but that won’t affect the following load because the upper half is ignored on the memory access anyway. So this is really 64 bit only.
>>
>> Yes, you are right.
>
> Should I add the #ifdef LP64 back or leave it as it is?

Leave as it is because, first, we don't support 32-bit SPARC anymore and, second, in other places (for different 
reasons) we don't use such #ifdef for signx(). Third, it is safe to execute it in 32-bit since code is still correct.

Vladimir

>
> Roland.
>


More information about the hotspot-compiler-dev mailing list