RFR (L) : 8014013 : CallInfo structure no longer accurately reports the result of a LinkResolver operation

[David Chase]

Revised webrev, based on comments from Coleen Phillimore.

http://cr.openjdk.java.net/~drchase/8014013/webrev.06/

There was some extraneous commented code from testing the cause of a changed error
(one faulty output was replaced with a different faulty output, the cause is not the fault of this change)
and another comment made an assertion that, when coded as an actual assertion, was proven
to be a lie.  So that comment was revised.

>   void LinkResolver::resolve_method_statically(methodHandle& resolved_method, KlassHandle& resolved_klass,
>                                                Bytecodes::Code code, constantPoolHandle pool, int index, TRAPS) {
> +   // This method is used only in C2 from InlineTree::ok_to_inline (via ciMethod::check_call),
> +   // and is only used under -Xcomp or -XX:CompileTheWorld.
> +   // It appears to fail when applied to an invokeinterface call site.
> +   // FIXME: Remove this method and ciMethod::check_call; refactor to use the other LinkResolver entry points.

> Can you assert (CompileTheWorld || compiler_mode == xcomp, "not supported");
> So someone not reading comments doesn't think they can call this?
> 
> Also there are commented out lines in methodHandles_<cpu>, which is somewhat disturbing.
> Why are they there and can you put a comment in the code about why they are there?

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: Message signed with OpenPGP using GPGMail
Url : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20130912/94db1aab/signature-0001.asc