RFR(XS) JDK-8024646: Remove LRG_List container, replace it with GrowableArray

Christian Thalinger christian.thalinger at oracle.com
Thu Sep 12 16:12:48 PDT 2013


On Sep 11, 2013, at 3:11 PM, Niclas Adlertz <niclas.adlertz at oracle.com> wrote:

>> It looks good. I would suggest to remove the line in coalesce.hpp instead of commenting.
> Thanks. That should be removed indeed.

After that it looks good.  -- Chris

> 
>> Could you file and fix a RFE about caching Thread::current()->resource_area() in Phase class?
>> There are a LOT of places in compiler where we use it and calling Thread::current() is not cheap.
> Sure.
> 
> Kind Regards,
> Niclas Adlertz
> 
> On 2013-09-11 21:10, Vladimir Kozlov wrote:
>> Niclas,
>> 
>> It looks good. I would suggest to remove the line in coalesce.hpp instead of commenting.
>> 
>> Could you file and fix a RFE about caching Thread::current()->resource_area() in Phase class?
>> There are a LOT of places in compiler where we use it and calling Thread::current() is not cheap.
>> 
>> Thanks,
>> Vladimir
>> 
>> On 9/11/13 11:09 AM, Niclas Adlertz wrote:
>>> Hi all,
>>> 
>>> While working on 8022783, I've found that LRG_List can be removed.
>>> LRG_List is just another growable array, so we can replace it with the
>>> more common implementation named class GrowableArray.
>>> 
>>> A review would be much appreciated.
>>> 
>>> WEBREV: http://cr.openjdk.java.net/~adlertz/JDK-8024646/webrev00/
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8024646
>>> 
>>> Kind Regards,
>>> Niclas Adlertz
> 



More information about the hotspot-compiler-dev mailing list