RFR(M) 8024924: Intrinsify java.lang.Math.addExact
Vladimir Kozlov
vladimir.kozlov at oracle.com
Thu Sep 19 11:15:08 PDT 2013
Rickard,
You need to provide more description for public and include the link to
the bug report which now is accessible from outside:
https://bugs.openjdk.java.net/browse/JDK-8024924
When result of MathExact is not used we should replace it with top to
remove uncommon trap.
I think it would be better to create new mathexactnode.?pp files for new
mathexact nodes. Our *node.?pp files become too fat.
In MultiNode::proj_out(proj) check is_FlagsProj() first since is_Proj()
is also true for it (since it is subclass).
Next test file misses Copyright header:
test/compiler/8024924/Verify.java
We are moving to creation of subcomponent subdirs for new tests. Could
you move that into test/compiler/intrinsic/8024924 ?
thanks,
Vladimir
On 9/18/13 11:55 AM, Rickard Bäckman wrote:
> Hi all,
>
> can I please have reviews for this change.
> Jump on overflow is implemented on x86 32&64-bit.
>
> http://cr.openjdk.java.net/~rbackman/8024924.1/
>
> Thanks
> /R
>
More information about the hotspot-compiler-dev
mailing list