RFR(M) 8024924: Intrinsify java.lang.Math.addExact

[Stefan Karlsson]

On 9/19/13 8:46 PM, Rickard Bäckman wrote:
> Vladimir,
>
> thanks for the review. I'll update the code accordingly.
>
> On Sep 19, 2013, at 8:15 PM, Vladimir Kozlov wrote:
>
>> Rickard,
>>
>> You need to provide more description for public and include the link to the bug report which now is accessible from outside:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8024924
> Sorry missed that one.
>
>> When result of MathExact is not used we should replace it with top to remove uncommon trap.
> You are saying that if the ProjNode (result) doesn't have an out we should replace the MathExact with top() right?
>
>> I think it would be better to create new mathexactnode.?pp files for new mathexact nodes. Our *node.?pp files become too fat.
> Good idea.
>
>> In MultiNode::proj_out(proj) check is_FlagsProj() first since is_Proj() is also true for it (since it is subclass).
> No it doesn't. is_Proj() is controlled by the macros in nodes.hpp. FlagsProjNode is a child of CmpNode there and can't be a member of both. I hit the assert in proj_out()
>
>> Next test file misses Copyright header:
>>
>> test/compiler/8024924/Verify.java
> Ok.
>
>> We are moving to creation of subcomponent subdirs for new tests. Could you move that into test/compiler/intrinsic/8024924 ?
> Ok.

For those who haven't seen this:
https://wiki.openjdk.java.net/display/HotSpot/Naming+HotSpot+JTReg+Tests

StefanK
>
> /R
>
>> thanks,
>> Vladimir
>>
>> On 9/18/13 11:55 AM, Rickard Bäckman wrote:
>>> Hi all,
>>>
>>> can I please have reviews for this change.
>>> Jump on overflow is implemented on x86 32&64-bit.
>>>
>>> http://cr.openjdk.java.net/~rbackman/8024924.1/
>>>
>>> Thanks
>>> /R
>>>