RFR (S): CR 8014447: Object.hashCode intrinsic breaks inline caches

Christian Thalinger christian.thalinger at oracle.com
Thu Sep 26 12:03:35 PDT 2013


On Sep 26, 2013, at 8:16 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> On 09/26/2013 07:03 PM, Vladimir Kozlov wrote:
>> Thank you, Aleksey, for verifying and testing these cases.
>> 
>> Based on this information I think your code is good.
> 
> Thanks for review, Vladimir. Here is the final webrev:
> http://cr.openjdk.java.net/~shade/8014447/webrev.02/

src/share/vm/opto/doCall.cpp:

+  // Nothing claimed the intrinsic, we go with with straight-forward inlining

Typo.

Otherwise this looks good.

> 
> I think we need a second reviewer?
> Also, I would need a sponsor to push this.
> 
> -Aleksey.



More information about the hotspot-compiler-dev mailing list