RFR (S): CR 8014447: Object.hashCode intrinsic breaks inline caches

[Christian Thalinger]

On Sep 27, 2013, at 12:54 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:

> On 09/26/2013 11:03 PM, Christian Thalinger wrote:
>> 
>> On Sep 26, 2013, at 8:16 AM, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>> 
>>> On 09/26/2013 07:03 PM, Vladimir Kozlov wrote:
>>>> Thank you, Aleksey, for verifying and testing these cases.
>>>> 
>>>> Based on this information I think your code is good.
>>> 
>>> Thanks for review, Vladimir. Here is the final webrev:
>>> http://cr.openjdk.java.net/~shade/8014447/webrev.02/
>> 
>> src/share/vm/opto/doCall.cpp:
>> 
>> +  // Nothing claimed the intrinsic, we go with with straight-forward inlining
>> 
>> Typo.
>> 
>> Otherwise this looks good.
> 
> Thanks Christian! I assume the typo is with double "with", not with my
> English :)

Exactly :-)

> 
> The updated webrev is here:
> http://cr.openjdk.java.net/~shade/8014447/webrev.03/
> 
> The changeset is here:
> http://cr.openjdk.java.net/~shade/8014447/8014447.changeset
> 
> I need a sponsor to push.

I will push this for you.

> 
> -Aleksey.
>