RFR(S): 8005079: fix LogCompilation for incremental inlining

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Apr 4 17:02:09 UTC 2014


Looks good.

Thanks,
Vladimir

On 4/4/14 1:37 AM, Roland Westrelin wrote:
> I haven’t pushed that fix yet and I found a couple minor issues that I would like to include:
>
> Here is a new webrev:
> http://cr.openjdk.java.net/~roland/8005079/webrev.05/
>
> and, to save some review time, what has changed since the last webrev:
> http://cr.openjdk.java.net/~roland/8005079/webrev.04-05/
>
> Roland.
>
> On Mar 26, 2014, at 5:03 PM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
>
>>> CICountOSR is off by default, osr compilations have compile_id in the same sequence as normal compilations. Only when CICountOSR is on its compile_id can match one of normal compilation id.
>>>
>>> And your formula is incorrect because produced id for compile_id = 2 will match id for osr_compile_id = 1, for example.
>>>
>>> If you want to keep low 32 bit for unique() you can shift more:
>>>
>>> ((jlong)compile_id())<<33 + (CICountOSR && is_osr_compilation() ? 1<<32 : 0);
>>
>> Ok. I’ll do that. Thanks Vladimir.
>>
>> Roland.
>


More information about the hotspot-compiler-dev mailing list