RFR(M): 8039407 : Regression test needed for JDK-8015396

[Gilles Duboscq]

On 8 Apr 2014 20:37, "Igor Ignatyev" <igor.ignatyev at oracle.com> wrote:
>
> Hi David,
>
> Why do you need to use String.valueOf(D)?
>
> I mean, why do you need this:
>>
>>   88         String modstring = String.valueOf(mod).toLowerCase();
>>   89         if (modstring.contains("nan")) {
>
> if you can write:
>>
>> if (mod == Double.NaN) {

Double.NaN == Double.NaN is false.
However there is a Double.isNaN(double) method.

-Gilles

>
>
>
> Thanks,
> Igor
>
>
> On 04/08/2014 10:23 PM, David Chase wrote:
>>
>> Bug 8015396 needs a regression test; I cannot reproduce it so there is
no "fix" to check in,
>> hence the separate bug to cover adding the test.  The test was included
with the bug report,
>> and has been adapted here to jtreg.
>>
>> webrev: http://cr.openjdk.java.net/~drchase/8039407/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8039407
>>
>> testing: I artificially stuffed a "NaN" into the result value and
observed that the test would then
>> report a failure.
>>
>> David
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140408/d3b454c9/attachment.html>