[9] RFR(S): 8039425: Code cleanup: PhaseIterGVN::optimize()

Albert albert.noll at oracle.com
Thu Apr 10 12:55:38 UTC 2014


Hi,

Vladimir, Rickard, thanks for looking at this. Rickard, I followed your 
suggestion
and made init_worklist iterative. Here is the new webrev:

http://cr.openjdk.java.net/~anoll/8039425/webrev.01/

Best,
Albert



On 04/10/2014 06:57 AM, Rickard Bäckman wrote:
> Albert,
>
> I think it looks good. (Not a Reviewer...).
> One thing I would have liked to see is making init_worklist
> iterative instead of recursive. I'm fine with it the way it is though.
>
> Thanks
> /R
>
> On 04/09, Albert wrote:
>> Hi,
>>
>> could I get reviews for this patch?
>>
>> *Bug:*
>> https://bugs.openjdk.java.net/browse/JDK-8039425
>>
>> *Problem:*
>> The code in PhaseIterGVN::optimize() is hard to read.
>>
>> *Solution:*
>> This code cleanup aims at improving code readability.
>>
>> *Webrev:*
>> http://cr.openjdk.java.net/~anoll/8039425/webrev.00/
>>
>> Many thanks in advance,
>> Albert



More information about the hotspot-compiler-dev mailing list