RFR(S): 8026694: New type profiling points break compilation replay
Roland Westrelin
roland.westrelin at oracle.com
Thu Apr 10 17:41:31 UTC 2014
Thanks for looking at this, Vladimir.
>> Anyone for this review?
>>
>> Roland.
>>
>> On Mar 25, 2014, at 10:51 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
>>
>>> http://cr.openjdk.java.net/~roland/8026694/webrev.00/
>>>
>>> If we want to still be able to read replay files generated before this change, the assert:
>>>
>>> src/share/vm/ci/ciReplay.cpp
>>> 1120 assert(m->_data_size + m->_extra_data_size == rec->_data_length * (int)sizeof(rec->_data[0]), "must agree”);
>>>
>>> needs to removed or changed (extra data from the MDO is not currently dumped).
>
> Are you asking what to do with the assert? Can you detect if replay file has extra data?
I’m asking if it matters whether we can load an old replay file with a new build.
Roland.
More information about the hotspot-compiler-dev
mailing list