[9] RFR(S): 8041468: Field nmethod::_lock_count should be declared volatile

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Apr 23 16:59:49 UTC 2014


Good.

Vladimir

On 4/23/14 3:20 AM, Tobias Hartmann wrote:
> Hi,
>
> please review the following patch that adds the missing volatile declaration to nmethod::_lock_count.
> I also changed the guarantees in nmethodLocker::lock_nmethod(...) and nmethodLocker::unlock_nmethod(...) to asserts
> because in my opinion a guarantee is too strong here (see for example GC_locker::increment_debug_jni_lock_count() where
> an assert is used as well).
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8041468
> Webrev: http://cr.openjdk.java.net/~anoll/8041468/webrev.00/ <http://cr.openjdk.java.net/%7Eanoll/8041468/webrev.00/>
>
> Tested with JPRT.
>
> Thanks,
> Tobias
>
>


More information about the hotspot-compiler-dev mailing list