RFR(XS): 8039960: Unexpected exit from test compiler/profiling/spectrapredefineclass/Launcher.java

Roland Westrelin roland.westrelin at oracle.com
Wed Apr 23 17:03:07 UTC 2014


Thanks for the review, Vladimir.

Roland.

On Apr 23, 2014, at 7:02 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Looks fine to me.
> 
> Vladimir
> 
> On 4/23/14 3:43 AM, Roland Westrelin wrote:
>> For the record, I got a review from Chris (who replied to me directly).
>> Thanks for the review, Chris!
>> I assume I can push it with a single review given how simple this is. So if nobody objects, I’ll do that tomorrow.
>> 
>> Roland.
>> 
>> Begin forwarded message:
>> 
>>> From: Christian Thalinger <christian.thalinger at oracle.com>
>>> Subject: Re: RFR(XS): 8039960: Unexpected exit from test compiler/profiling/spectrapredefineclass/Launcher.java
>>> Date: April 23, 2014 at 12:09:20 AM GMT+2
>>> To: Roland Westrelin <roland.westrelin at oracle.com>
>>> 
>>> Looks good.
>>> 
>>> On Apr 22, 2014, at 5:09 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:
>>> 
>>>> As Chris points in the bug comments, there’s no need to restrict the heap size in this test. I also removed some dead code.
>>>> 
>>>> http://cr.openjdk.java.net/~roland/8039960/webrev.00/
>>>> 
>>>> Roland.
>>> 
>> 



More information about the hotspot-compiler-dev mailing list