RFR(S): 8040920: Uninitialised memory in hotspot/src/share/vm/code/dependencies.cpp

[Christian Thalinger]

src/share/vm/code/dependencies.cpp

+    GrowableArray<ciBaseObject*>* ciargs = new GrowableArray<ciBaseObject*>(stride);
It doesn’t really matter since it’s growable but the initial size should be deps->length().
       char xn[10]; sprintf(xn, "x%d", j);
Ugh.  I just saw this code.  Could you change that snprintf while you are already there?

Did you try to run with LogCompilation on and verified the output?

Otherwise this looks good.  Nice cleanup!

On Apr 24, 2014, at 6:30 AM, Morris Meyer <morris.meyer at oracle.com> wrote:

> Folks,
> 
> Could I get a review for this parfait issue?  I've refactored dependencies to use a GrowableArray to protect from inconsistencies in passed in argument pairs (int nargs, DepArgument args[])
> 
> Thanks to Christian Thalinger and Vladimir Kozlov for looking at earlier versions of this.
> 
>        --morris
> 
> JBS - https://bugs.openjdk.java.net/browse/JDK-8040920
> WEBREV - http://cr.openjdk.java.net/~morris/JDK-8040920.04
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140424/26e9c963/attachment.html>