RFR(M): 8039407 : Regression test needed for JDK-8015396

David Chase david.r.chase at oracle.com
Fri Apr 25 23:40:20 UTC 2014


Thanks very much.

David

On 2014-04-25, at 7:20 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Perfect.
> 
> Thanks,
> Vladimir
> 
> On 4/25/14 4:20 PM, David Chase wrote:
>> How's this?
>> 
>> http://cr.openjdk.java.net/~drchase/8039407/webrev.04/
>> 
>> David
>> 
>> On 2014-04-25, at 4:48 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>>> David,
>>> 
>>> David,
>>> 
>>> You don't need /othervm if there are no additional command flags.
>>> 
>>> I still want to see in the comment which hex numbers corresponds to which doubles.
>>> 
>>> Thanks,
>>> Vladimir
>>> 
>>> On 4/25/14 1:02 PM, David Chase wrote:
>>>> new webrev: http://cr.openjdk.java.net/~drchase/8039407/webrev.02/
>>>> 
>>>> Modified to run interpreted (bug was observed in the field with -Xint)
>>>> but to iterate 10,000 times, then sleep for a second, then 10 more times
>>>> in case it is liked to compilation, and two versions of the test method
>>>> are tried, one strictfp, the other not.
>>>> 
>>>> The bug has never been reproduced by us.
>>>> 
>>>> David
>>>> 
>>>> On 2014-04-17, at 3:32 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>>>> 
>>>>> Hi David,
>>>>> 
>>>>> Can you use next style for the comment?
>>>>> 
>>>>> /*
>>>>> *
>>>>> */
>>>>> 
>>>>> And it would be good to see corresponding hex values in the comment which you use later in the code.
>>>>> 
>>>>> The comment needs more explanation what it is all about and why you are listing particular Windows machines configurations.
>>>>> 
>>>>> This test will test only Intepreter and not compiled jited code. You need at lest 3 iterations for compiled code to be used even with -Xcomp. I would suggest to create separate methods and call them from main() in a loop.
>>>>> 
>>>>> About bug itself. Was you able to reproduce the failure? It is not clear from report.
>>>> 
>> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140425/ac08c193/signature.asc>


More information about the hotspot-compiler-dev mailing list