[9] RFR(M): JDK-8036956: remove EnableInvokeDynamic flag

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Apr 28 18:24:30 UTC 2014


Yes, we can :)

Vladimir

On 4/28/14 5:22 AM, Tobias Hartmann wrote:
> Hi,
>
> the CCC request has been approved. Can we push the changes?
>
> Thanks,
> Tobias
>
> On 04/15/2014 10:29 PM, Vladimir Kozlov wrote:
>> Okay, lets wait. It could be good exercise for Tobias.
>>
>> Vladimir
>>
>> On 4/15/14 12:54 PM, Igor Ignatyev wrote:
>>> Vladimir,
>>>
>>> I don't insist on having CCC, but my understating is what we have to
>>> file a CCC, since this flag can be available in product builds.
>>> Anyway Tobias already has filed a CCC request, so we can wait for the
>>> decision, just to be sure that we're OK.
>>>
>>> Igor
>>>
>>> On 04/15/2014 09:09 PM, Vladimir Kozlov wrote:
>>>> Igor,
>>>>
>>>> we don't need CCC because the flag is diagnostic and not product.
>>>>
>>>> Thanks,
>>>> Vladimir
>>>>
>>>> On 4/15/14 3:23 AM, Igor Ignatyev wrote:
>>>>> Hi Tobias,
>>>>>
>>>>> Do you have CCC for this?
>>>>>
>>>>> Igor
>>>>>
>>>>> On 04/15/2014 02:12 PM, Tobias Hartmann wrote:
>>>>>> Vladimir, Christian, thanks for the reviews!
>>>>>>
>>>>>>
>>>>>> On 04/14/2014 10:55 PM, Christian Thalinger wrote:
>>>>>>> On Apr 14, 2014, at 7:32 AM, Vladimir
>>>>>>> Kozlov<vladimir.kozlov at oracle.com>  wrote:
>>>>>>>
>>>>>>>> Hi Tobias,
>>>>>>>>
>>>>>>>> I think, in javaClasses.cpp computing _form_offset should not be
>>>>>>>> optional.
>>>>>>> Yes.
>>>>>> True, missed that one. Please find the updated webrev at:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~anoll/8036956/webrev.01/
>>>>>> <http://cr.openjdk.java.net/%7Eanoll/8036956/webrev.01/>
>>>>>>
>>>>>> Thanks,
>>>>>> Tobias
>>>>>>
>>>>>>>> Otherwise it looks good.
>>>>>>> I agree.  Looks good.
>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Vladimir
>>>>>>>>
>>>>>>>> On 4/13/14 11:56 PM, Tobias Hartmann wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> please review the following patch for bug 8036956.
>>>>>>>>>
>>>>>>>>> *Problem:*
>>>>>>>>> The VM option EnableInvokeDynamic is not longer used in JDK 9. It
>>>>>>>>> is enabled by default and it is not possible to run
>>>>>>>>> HotSpot in JDK9 without it (see bug description).
>>>>>>>>> Bug:https://bugs.openjdk.java.net/browse/JDK-8036956
>>>>>>>>> *
>>>>>>>>> **Solution:*
>>>>>>>>> The EnableInvokeDynamic flag and all support code is removed.
>>>>>>>>> Webrev:http://cr.openjdk.java.net/~anoll/8036956/webrev.00/
>>>>>>>>> <http://cr.openjdk.java.net/%7Eanoll/8036956/webrev.00/>
>>>>>>>>>
>>>>>>>>> *Tests:*
>>>>>>>>> JPRT
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Tobias
>>>>>>
>


More information about the hotspot-compiler-dev mailing list