[9] RFR(XS): 8042052: assert(t != NULL) failed: must set before get

Tobias Hartmann Tobias.Hartmann at oracle.com
Wed Apr 30 14:30:18 UTC 2014


Hi,

please review the following patch for bug 8042052.

*Problem*
The changes introduced by the fix for 8041912 [1] removed the call to 
set_result(...) in LibraryCallKit::finish_pow_exp(...) that called 
gvn.transform on the PhiNode results_val. The type of the PhiNode is 
therefore not recorded in the gvn. The PhiNode is returned and later 
accessed as an input to a StoreNode in 
PhaseGVN::transform_no_reclaim(...). The call to StoreNode::Value tries 
to look up the type of the PhiNode and triggers the assert in 
PhaseTransform::type(...) because the type is not set.

Bug: https://bugs.openjdk.java.net/browse/JDK-8042052

*Solution*
A call to _gvn.transform is added to make sure the type of the PhiNode 
is recorded.

Webrev: http://cr.openjdk.java.net/~anoll/8042052/webrev.00/

*Tests:*
Failing test (testMathExpDouble), JPRT

Thanks,
Tobias

[1] https://bugs.openjdk.java.net/browse/JDK-8041912
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140430/9ac56ff2/attachment.html>


More information about the hotspot-compiler-dev mailing list