RFR(XXS) : 8042214: add @ignore tag to all excluded jtreg tests in test/compiler

Igor Ignatyev igor.ignatyev at oracle.com
Wed Apr 30 20:01:23 UTC 2014


Vladimir,

> Please, explain the usage of @ignore tag.

@ignore tag is a regular tag from jtreg, excerpt from jtreg spec[1]:
> ACTION TYPES
> ...
> ignore <word>*
>
> Ignore this and all following @run tags.  A test harness may treat this test as
> a failure or as some other type of error.  The <word> tokens, if any, should
> describe why the test is being ignored.  These tokens may be displayed by the
> harness in some appropriate fashion.


> Will these tests run during nightly testing or not?
the tests marked by this tag won't be run during all testing including 
nightly, PIT, promotion. As they do now, since there's open bugs w/ 
'test-exclude' label; namely JDK-8033553, JDK-8032498, JDK-7117034, 
JDK-7154567.

Fixing these bugs is our (SQE team) high priority task, but we need to 
add @ignore tag due to upcoming changes in  exclusion mechanism.

> How we know when the tag should be removed?
the tag should be removed by the fix for the bug (usually it's a 
testbug) mentioned after the tag, e.g. @ignore should be removed from 
compiler/5091921/Test7005594.java by the fix for JDK-7117034:
test/compiler/5091921/Test7005594.java.html
>   28  * @ignore 7117034

[1] http://openjdk.java.net/jtreg/tag-spec.txt

Igor

On 04/30/2014 09:53 PM, Vladimir Kozlov wrote:
> Igor,
>
> Please, explain the usage of @ignore tag.
> Will these tests run during nightly testing or not?
> How we know when the tag should be removed?
>
> Thanks,
> Vladimir
>
> On 4/30/14 6:06 AM, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8042214/webrev.00/
>> 8 lines changed: 4 ins; 0 del; 4 mod;
>>
>> Hi all,
>>
>> Please review the patch which add @ignore tag to the tests which can
>> break test execution.
>>
>> jbs: https://bugs.openjdk.java.net/browse/JDK-8042214


More information about the hotspot-compiler-dev mailing list