RFR(S): 8040920: Uninitialised memory in hotspot/src/share/vm/code/dependencies.cpp

[Vladimir Kozlov]

Morris,

How you verified that you put ResourceMark in all needed places?
That is what I don't like about GrowableArray.

Thanks,
Vladimir

On 4/30/14 11:47 AM, Morris Meyer wrote:
> Vladimir and Christian,
>
> Thank you for the reviews.
>
> This version has your comments incorporated and has been put through
> JPRT and passes Parfait cleanly.
>
>          --mm
>
> JBS - https://bugs.openjdk.java.net/browse/JDK-8040920
> WEBREV - http://cr.openjdk.java.net/~morris/JDK-8040920.05
>
>
> On 4/24/14, 2:16 PM, Vladimir Kozlov wrote:
>> Using GrowableArray requires adding ResourceMark otherwise it will be
>> memory leak. Method clear() does not free resources.
>>
>> Vladimir
>>
>> On 4/24/14 9:30 AM, Morris Meyer wrote:
>>> Folks,
>>>
>>> Could I get a review for this parfait issue?  I've refactored
>>> dependencies to use a GrowableArray to protect from inconsistencies in
>>> passed in argument pairs (int nargs, DepArgument args[])
>>>
>>> Thanks to Christian Thalinger and Vladimir Kozlov for looking at earlier
>>> versions of this.
>>>
>>>          --morris
>>>
>>> JBS - https://bugs.openjdk.java.net/browse/JDK-8040920
>>> WEBREV - http://cr.openjdk.java.net/~morris/JDK-8040920.04
>>>
>