RFR (M) CR 8050147: StoreLoad barrier interferes with stack usages

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Aug 11 22:30:53 UTC 2014


Hi, Aleksey

You may need to modify Compile::bang_size_in_bytes() and 
LIR_Assembler::bang_size_in_bytes() to bang correct number of pages. Try 
to test with small stacks and see 
test/compiler/uncommontrap/StackOverflowGuardPagesOff.java.

Related problems fixed recently:
https://bugs.openjdk.java.net/browse/JDK-8026775
https://bugs.openjdk.java.net/browse/JDK-8032410

Thanks,
Vladimir

On 8/11/14 2:49 PM, Aleksey Shipilev wrote:
> On 08/12/2014 01:44 AM, John Rose wrote:
>>> If so, we can go with this:
>>> http://cr.openjdk.java.net/~shade/8050147/webrev.04/
>>> <http://cr.openjdk.java.net/%7Eshade/8050147/webrev.04/>
>>
>> Yes, please.
>
> Thanks for the review!
>
> This patch passes full JPRT, works fine with benchmarks on my laptop. I
> would assume it works well on larger workloads and larger machines,
> since we have already tested SP(CL-8) and SP(-8) with similar
> characteristics.
>
> I need a sponsor.
>
> Thanks,
> -Aleksey.
>


More information about the hotspot-compiler-dev mailing list