[9] RFR(S): 8043913: remove legacy code in SPARC's VM_Version::platform_features

[Zoltán Majó]

Hi Vladimir,


thank you for the review!


On 08/12/2014 03:08 PM, Vladimir Kozlov wrote:
> I would suggest to replace next removed check with assert to make sure 
> we have getisax:
>
> if (os::Solaris::supports_getisax())

I added the assert, here is the updated webrev:

http://cr.openjdk.java.net/~thartmann/8043913/webrev.01/

I ran again the JPRT "hotspot_compiler" test on solaris_sparc_v9*.

Best regards,


Zoltan

>
> Otherwise it looks good.
>
> Thanks,
> Vladimir
>
> On 8/12/14 12:12 AM, Zoltán Majó wrote:
>> Hi,
>>
>>
>> please remove the following patch.
>>
>> Problem: Since on SPARC we are now building/running on Solaris 10 and 
>> up, legacy code in the method
>> VM_Version::platform_features can be removed.
>>
>> Solution: The getisax(2) call is available from Solaris 10, therefore 
>> legacy code to determine platform features can be
>> removed. Solaris 10 defines some of the AV* constants used in the 
>> method. Some of these defines could have been removed
>> as well, but different versions of Solaris 10 define different 
>> subsets of the constants, therefore it is better to leave
>> the defines for now.
>>
>> Webrev: http://cr.openjdk.java.net/~thartmann/8043913/webrev.00/
>>
>> Testing:
>>
>> - built JVM on solaris_sparc_5.10u5 and on solaris_sparc_5.11.1;
>> - ran all JPRT tests on the solaris_sparcv9* platform;
>> - ran test/sanity/ExecuteInternalVMTests.java (the test executed by 
>> the "hotspot_compiler" JPRT test) on
>> solaris_sparc_5.11.1, solaris_sparc_5.10u5, and solaris_sparc_5.10u6
>>
>> Thank you and best regards,
>>
>>
>> Zoltan
>>