[9] RFR(S): 8055286: Extend CompileCommand=option to handle numeric parameters

[Vladimir Kozlov]

Hi Zoltan,

Sometimes we specify flag which is not declared as global flag in globals.hpp, for example NoRTMLockEliding. Please, 
don't remove such ability:

+           Flag *declared_flag = Flag::find_flag(flag, strlen(flag));

Flags specified in 'option' command do not affect global flags. We use the same name only for convenience.

Could you move new option code from parse_from_line() method to separate method()?

Also parts of that code also could be factored out, like codes which process 'intx' and 'uintx' values - they are very 
similar.

Use 'Klass' in second line too:
+       // (1) CompileCommand=option,Klass::method,flag
+       // (2) CompileCommand=option,KLASS::method,type,flag,value

Thanks,
Vladimir

On 8/22/14 2:12 AM, Zoltán Majó wrote:
> Hi,
>
>
> please review the following patch.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8055286
>
> Problem: Currently, CompileCommand=option handles only flags of type bool. CompileCommand=option should be extended to
> handle numeric types as well.
>
> Solution: This patch adds support for processing flags of type intx and uintx (in addition flags of type bool). Support
> for flags of type ccstr and ccstrlist is not added by this patch; we can add support for those types when it is needed.
>
> Webrev: http://cr.openjdk.java.net/~zmajo/8055286/
>
> Testing: JPRT, manual testing
>
> Thank you and best regards,
>
>
> Zoltan
>