[9] RFR (L): JDK-8055903: Develop sanity tests on SPARC's SHA instructions support

Filipp Zhinkin filipp.zhinkin at oracle.com
Fri Aug 29 16:37:31 UTC 2014


Vladimir,

On 29.08.2014 20:32, Vladimir Kozlov wrote:
> So it is mostly verification that intrinsic is used. 
Right.
> The code looks fine.
> But what about testing that intrinsic produce correct data?
It is done by compiler/intrinsics/sha/TestSHA.java test:
http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/file/3a2d373abcab/test/compiler/intrinsics/sha/TestSHA.java#l104

Thanks,
Filipp.
>
> Thanks,
> Vladimir
>
> On 8/29/14 7:45 AM, Filipp Zhinkin wrote:
>> Hi all,
>>
>> please review sanity tests on SHA intrinsics support.
>>
>> Tests verify that appropriate intrinsic is emitted whencorresponding
>> option is enabled and not emitted ifsuch option is disabled.
>>
>> In case when CPU does not support required instructions or
>> JVM configuration does not allow to use an intrinsic,
>> the test will expect that intrinsic will not be emitted.
>>
>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8055903
>> Webrev: http://cr.openjdk.java.net/~fzhinkin/8055903/webrev.00/
>> Testing: manual, automated.
>>
>> Thanks,
>> Filipp.



More information about the hotspot-compiler-dev mailing list