8066103: C2's range check smearing allows out of bound array accesses

[Paul Sandoz]

On Dec 3, 2014, at 6:14 AM, John Rose <john.r.rose at oracle.com> wrote:

> Reviewed.
> 
> The test cases are very good.  

I agree, as an outsider looking in they are really valuable and useful to reverse engineer the often mysterious workings of the compiler.

 
> One suggestion:  Use a driver routine to warm up, execute, and verify all the tests.

+1 the repetition makes it harder to read/maintain. I am not sure what John suggests but since all methods can support the same signature you could create a functional interface for the signature (int[], int, boolean)int and sprinkle some method refs around to avoid the boiler plate of inner classes for each test (assuming indy does not get in the way of the compiler doing what is to be tested). 

e.g.:

  test(TestRangeCheckSmearing::m1);
  test(TestRangeCheckSmearing::m2);

etc.

Paul.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20141203/580a5a27/signature.asc>