RFR (XS): 8065134: Need WhiteBox::allocateCodeBlob(long, int) method to be implemented

[Vladimir Kozlov]

Good.

Thanks,
Vladimir

On 12/4/14 9:54 AM, Tatiana Pivovarova wrote:
> Hi Vladimir,
>
> Thank you for your reviews.
>
> On 12/04/2014 08:01 PM, Vladimir Kozlov wrote:
>> I think you need to add cast from long to int:
>>
>> 949 WB_ENTRY(jlong, WB_AllocateCodeBlob(JNIEnv* env, jobject o, jlong
>> size, jint blob_type))
>> 950     return (jlong) WhiteBox::allocate_code_blob((int)size,
>> blob_type);
>>
> You are right. I added this fix.
> webrev: http://cr.openjdk.java.net/~ppunegov/tpivovarova/8065134/webrev.01/
>
> Thanks,
> Tatiana
>
>> since:
>>
>> WhiteBox::allocate_code_blob(int size, int blob_type) {
>>
>> Otherwise some C++ compiler may complain.
>>
>> Thanks,
>> Vladimir
>>
>> On 12/4/14 8:34 AM, Tatiana Pivovarova wrote:
>>> Hi all,
>>>
>>> please review this small patch
>>>
>>> bugid: https://bugs.openjdk.java.net/browse/JDK-8065134
>>> webrev:
>>> http://cr.openjdk.java.net/~iignatyev/tpivovarova/8065134/webrev.00
>>>
>>> Problem:
>>> Need WhiteBox::allocateCodeBlob(long, int), currently only
>>> WhiteBox::allocateCodeBlob(int, int) exist.
>>>
>>> Solution:
>>> Just change function signature WhiteBox::allocateCodeBlob(int, int)
>>> -> WhiteBox::allocateCodeBlob(long, int)
>>>
>>> Test: jprt
>>>
>>> Thanks,
>>> Tatiana
>