RFR (XS): 8065134: Need WhiteBox::allocateCodeBlob(long, int) method to be implemented

[David Holmes]

On 5/12/2014 10:37 PM, Tatiana Pivovarova wrote:
> Hi all,
>
> please review this new small patch
>
> bugid: https://bugs.openjdk.java.net/browse/JDK-8065134
> webrev: http://cr.openjdk.java.net/~ppunegov/tpivovarova/8065134/webrev.02/
>
> Problem:
> Need WhiteBox::allocateCodeBlob(long, int), currently only
> WhiteBox::allocateCodeBlob(int, int) exist.
>
> I change previous fix to this new patch because this conversation [*]
>
> Solution:
>    public long allocateCodeBlob(long size, int type) {
>        return allocateCodeBlob((int) size, type);
>    }

I still think this is a bad idea. The callsite needs to know, and show, 
that the size it is passing will be truncated. And I still don't see a 
connection between MX bean memory sizes and allocateCodeBlob.

David


> Test: jprt
>
> [*]
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-December/016316.html
>
>
> Thanks,
> Tatiana