RFR: 8059613 -JEP-JDK-8043304: Test task: JMX- tests and JDK-8066440 - Various changes in testlibrary for JDK-8059613

Staffan Larsen staffan.larsen at oracle.com
Mon Dec 8 06:59:22 UTC 2014


I still don’t think this looks general-purpose enough to have it included in the general test library. If you need a parameter for your tests, then I would suggest adding it to some class under test/compiler/codecache. 

/Staffan

> On 5 dec 2014, at 22:28, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Hi Staffan,
> 
> Utils.ITERATION_COUNT will be extremely useful during porting our existing tests. so I'd like to have it in common testlibrary.
> 
> Thanks
> Igor
> 
> On 12/05/2014 11:13 PM, Dmitrij Pochepko wrote:
>> During internal team review, Igor.Igntatyev asked to move it to Utils,
>> perhaps he has future plans for this.
>> Igor?
>> 
>> Thanks,
>> Dmitrij
>>> Utils.ITERATION_COUNT does not look like something that is usable
>>> outside these specific tests? Should it really be part of the test
>>> library?
>>> 
>>>> On 5 dec 2014, at 18:18, Dmitrij
>>>> Pochepko<Dmitrij.Pochepko at oracle.COM>  wrote:
>>>> 
>>>> Adding hotspot-dev for wider audience.
>>>>> Hi,
>>>>> 
>>>>> Please review changes for
>>>>> https://bugs.openjdk.java.net/browse/JDK-8059613 - JEP-JDK-8043304:
>>>>> Test task: JMX- tests
>>>>> and
>>>>> https://bugs.openjdk.java.net/browse/JDK-8066440 - Various changes
>>>>> in testlibrary for JDK-8059613
>>>>> 
>>>>> It introduce a number of tests for segmented code cache, mostly
>>>>> testing thresholds, usage,
>>>>> memory notifications using respective MemoryPoolMXBean(s).
>>>>> There is also a small modification for testlibrary(8066440) used in
>>>>> tests.
>>>>> 
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~iignatyev/dpochepk/8059613/webrev.01/
>>>>> 
>>>>> Testing: manually, using fastdebug nightly build from 2014-12-02
>>>>> 
>>>>> Additional note: this patch assumes
>>>>> "https://bugs.openjdk.java.net/browse/JDK-8065134 -
>>>>> Need WhiteBox::allocateCodeBlob(long, int) method to be implemented"
>>>>> is fixed.
>>>>> 
>>>>> Thanks,
>>>>> Dmitrij
>> 



More information about the hotspot-compiler-dev mailing list