RFR (XS): 8065134: Need WhiteBox::allocateCodeBlob(long, int) method to be implemented

David Holmes david.holmes at oracle.com
Tue Dec 9 01:10:12 UTC 2014


On 9/12/2014 3:06 AM, Vladimir Kozlov wrote:
> The webrev is wrong, should be
>
> http://cr.openjdk.java.net/~ppunegov/tpivovarova/8065134/webrev.03/
>
> which looks good.

Agreed.

Thanks for your patience everyone.

David

> Thanks,
> Vladimir
>
> On 12/8/14 8:49 AM, Tatiana Pivovarova wrote:
>> Hi all,
>>
>> please review this new patch
>>
>> bugid: https://bugs.openjdk.java.net/browse/JDK-8065134
>> webrev:
>> http://cr.openjdk.java.net/~ppunegov/tpivovarova/8065134/webrev.02/
>>
>> Problem:
>> Need WhiteBox::allocateCodeBlob(long, int), currently only
>> WhiteBox::allocateCodeBlob(int, int) exist.
>>
>> Solution:
>> Add new function with check:
>>
>>   156   public        long    allocateCodeBlob(long size, int type) {
>>   157       int intSize = (int) size;
>>   158       if ((long) intSize != size || size < 0) {
>>   159           throw new IllegalArgumentException(
>>   160                 "size argument has illegal value " + size);
>>   161       }
>>   162       return allocateCodeBlob( intSize, type);
>>   163   }
>>
>>
>> Test: jprt
>>
>>
>> Thanks,
>> Tatiana


More information about the hotspot-compiler-dev mailing list