RFR(XXS) 8066900: Array Out Of Bounds Exception causes variable corruption

Igor Veresov igor.veresov at oracle.com
Wed Dec 10 03:46:09 UTC 2014


Sorry, Dean, I already pushed it before I saw your email.

igor
 
> On Dec 9, 2014, at 4:25 PM, Dean Long <dean.long at oracle.com> wrote:
> 
> One small comment:  can you use something like this to make it even more clear:
> 
> bool save_fpu_registers =(id != handle_exception_nofpu_id);
> 
>     oop_map = save_live_registers(sasm, 1 /*thread*/,save_fpu_registers);
> 
>     restore_live_registers(sasm,save_fpu_registers);
> 
> otherwise it looks good.
> 
> dl
> 
> On 12/9/2014 11:07 AM, Igor Veresov wrote:
>>> On Dec 9, 2014, at 10:54 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>>> 
>>> Looks good.
>>> 
>> Thanks!
>> 
>>> Can you use 4 space indentation in the test?
>>> 
>> Sure, I’ll fix that.
>> 
>>> Best regards,
>>> Vladimir Ivanov
>>> 
>>> On 12/9/14, 9:05 PM, Igor Veresov wrote:
>>>> C1 does the opposite of the right thing when saving the registers during
>>>> exception handling on x86. Other platforms seem fine.
>>>> 
>>>> Webrev: http://cr.openjdk.java.net/~iveresov/8066900/webrev.00/
>>>> 
>>>> Thanks,
>>>> igor
> 



More information about the hotspot-compiler-dev mailing list