RFR: 8059551: JEP-JDK-8043304: Test task: stress tests

David Chase david.r.chase at oracle.com
Thu Dec 11 16:31:42 UTC 2014


Also looks good, except for two extremely picky details

1.  "Exception occured during test method execution"
     should be "occurred" (two R's), string occurs twice in patch.

and (very picky)

2. "TESTBUG: lockUnlock'er thread was unexpectedly interrupted"
 I think maybe "lockUnlock-er" or even  "lockUnlocker".

( ' in a word implies omitted letters, "don't" for "do not", 'n' for "and" )

Again, tiny details, but if you haven't pushed yet....

David

On 2014-12-09, at 11:50 AM, Pavel Chistyakov <pavel.chistyakov at oracle.com> wrote:

> Hi all,
> 
> please review changes for: https://bugs.openjdk.java.net/browse/JDK-8059551
> webrev: http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.00/
> 
> It introduces several stress tests for segmented code cache. There are main thread that calls given method and checks its return value and several testing threads:
> 	• OverloadCompileQueueTest - locks compilation for random time periods trying to full compile queues and to break tested method compilation;
> 	• RandomAllocationTest - randomly allocates and removes "dummy" code blobs in different code cache heaps tries to corrupt tested method code in code cache;
> 	• UnexpectedDeoptimizationTest - deoptimizes on stack frames in random times tries to break tested method execution/return value
> 
> Testing: manual
> 
> -------------------
> Thanks,
> Pavel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20141211/2eaff295/signature.asc>


More information about the hotspot-compiler-dev mailing list