RFR(S): 8067211: rewrite Utils::fileAsString

Tatiana Pivovarova tatiana.pivovarova at oracle.com
Fri Dec 12 12:46:19 UTC 2014


Added hotspot-dev at openjdk.java.net

On 12/12/2014 03:37 PM, Tatiana Pivovarova wrote:
> Hi all,
>
> please review this small patch
>
> bugid: https://bugs.openjdk.java.net/browse/JDK-8067211
> webrev: 
> http://cr.openjdk.java.net/~ppunegov/tpivovarova/8067211/webrev.00/
>
> Problem:
> Utils::fileAsString implementation has several issues:
>  - using '\n' instead of platform independent EOL
>  - catching wide spectre of exceptions and "ignoring" them
>  - partially duplicates code of Utils::fileAsList method which 
> duplicates File::readAllLines
>
> Solution:
>  - using library method for reading lines
>  - using system property for EndOfLine.
>
> Testing: jprt
>
> Thanks,
> Tatiana



More information about the hotspot-compiler-dev mailing list