RFR: 8059551: JEP-JDK-8043304: Test task: stress tests

Igor Ignatyev igor.ignatyev at oracle.com
Mon Dec 15 13:34:26 UTC 2014


Pavel,

http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.02/test/compiler/codecache/stress/Helper.java.html 


> 45             CLASS_DATA = loadClassData(TestCaseImpl.class.getName());
> 95             String className = TestCaseImpl.class.getName();

these lines will load 'TestCaseImpl' class via default class loader, 
could you try to avoid it?

Igor

On 12/15/2014 04:15 PM, Pavel Chistyakov wrote:
> Hi,
>
> please take a look into slightly updated webrev:
> http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.02/
> <http://cr.openjdk.java.net/%7Eiignatyev/pchistyakov/8059551/webrev.02/>
>
> --------------
> Thanks,
> Pavel
>
> On 12.12.2014 23:05, Vladimir Kozlov wrote:
>> Looks fine.
>>
>> Thanks,
>> Vladimir
>>
>> On 12/12/14 6:07 AM, David Chase wrote:
>>>
>>> On 2014-12-12, at 5:14 AM, Pavel Chistyakov
>>> <pavel.chistyakov at oracle.com> wrote:
>>>
>>>> David, thank you for review.
>>>> Here is updated webrev:
>>>> http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.01
>>>> <http://cr.openjdk.java.net/%7Eiignatyev/pchistyakov/8059551/webrev.01>
>>>
>>> That is excellent -- now we just need a real reviewer.
>>>
>>> David
>>>
>


More information about the hotspot-compiler-dev mailing list