RFR: 8059551: JEP-JDK-8043304: Test task: stress tests

[Christian Thalinger]

> On Dec 22, 2014, at 2:31 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Chris,
> 
>>> It’s 2015 (soon); we really don’t have to stay under 80 characters.
> I'll argue about 80 characters limitation. we do have to at least try to stay under 80, because there are 2 buffer diff-view, and it's literally impossible to use it in case of more than 80 characters, even now in 2015. I recall the review there it looked like nothing was changed, because length of line was longer than my monitor can include, and I spent some time trying to figured out why the file was shown as modified.
> 
> so I'd prefer to have good old 80 characters.

http://en.wikipedia.org/wiki/Punched_card#IBM_80-column_punched_card_formats_and_character_codes <http://en.wikipedia.org/wiki/Punched_card#IBM_80-column_punched_card_formats_and_character_codes>

> 
> Igor
> 
> On 12/23/2014 01:13 AM, Christian Thalinger wrote:
>> Can we keep these on the same line?
>> 
>>   44 public class OverloadCompileQueueTest implements Runnable {
>> 
>>   49     private static final boolean INTERPRETED
>>   50             = System.getProperty("java.vm.info").startsWith("interpreted ");
>>   51     private static final boolean TIERED_COMPILATION
>>   52             = Helper.WHITE_BOX.getBooleanVMFlag("TieredCompilation");
>>   53     private static final int TIERED_STOP_AT_LEVEL
>>   54             = Helper.WHITE_BOX.getIntxVMFlag("TieredStopAtLevel").intValue();
>> 
>> 
>>   43 public class RandomAllocationTest implements Runnable {
>>   44     private static final long CODE_CACHE_SIZE
>>   45             = Helper.WHITE_BOX.getUintxVMFlag("ReservedCodeCacheSize");
>>   46     private static final int MAX_BLOB_SIZE = (int) (CODE_CACHE_SIZE >> 7);
>>   47     private static final BlobType[] BLOB_TYPES
>>   48             = BlobType.getAvailable().toArray(new BlobType[0]);
>> 
>> 
>> It’s 2015 (soon); we really don’t have to stay under 80 characters.
>> 
>> Otherwise this looks good.
>> 
>>> On Dec 19, 2014, at 2:53 AM, Pavel Chistyakov
>>> <pavel.chistyakov at oracle.com <mailto:pavel.chistyakov at oracle.com> <mailto:pavel.chistyakov at oracle.com <mailto:pavel.chistyakov at oracle.com>>> wrote:
>>> 
>>> Hi Christian,
>>> 
>>> Yes, here is updated version:
>>> http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.03 <http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.03>
>>> Could you please take a look into it?
>>> 
>>> --------
>>> Thanks,
>>> Pavel
>>> 
>>> ----- Original Message -----
>>> From: christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>
>>> <mailto:christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>>
>>> To: igor.ignatyev at oracle.com <mailto:igor.ignatyev at oracle.com> <mailto:igor.ignatyev at oracle.com <mailto:igor.ignatyev at oracle.com>>
>>> Cc: pavel.chistyakov at oracle.com <mailto:pavel.chistyakov at oracle.com> <mailto:pavel.chistyakov at oracle.com <mailto:pavel.chistyakov at oracle.com>>,
>>> hotspot-compiler-dev at openjdk.java.net <mailto:hotspot-compiler-dev at openjdk.java.net>
>>> <mailto:hotspot-compiler-dev at openjdk.java.net <mailto:hotspot-compiler-dev at openjdk.java.net>>
>>> Sent: Friday, December 19, 2014 1:17:48 AM GMT +04:00 Abu Dhabi / Muscat
>>> Subject: Re: RFR: 8059551: JEP-JDK-8043304: Test task: stress tests
>>> 
>>> 
>>>> On Dec 15, 2014, at 5:34 AM, Igor Ignatyev <igor.ignatyev at oracle.com <mailto:igor.ignatyev at oracle.com>
>>>> <mailto:igor.ignatyev at oracle.com <mailto:igor.ignatyev at oracle.com>>> wrote:
>>>> 
>>>> Pavel,
>>>> 
>>>> http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.02/test/compiler/codecache/stress/Helper.java.html
>>>> 
>>>> 
>>>>> 45             CLASS_DATA = loadClassData(TestCaseImpl.class.getName());
>>>>> 95             String className = TestCaseImpl.class.getName();
>>>> 
>>>> these lines will load 'TestCaseImpl' class via default class loader,
>>>> could you try to avoid it?
>>> 
>>> Any update on that?
>>> 
>>>> 
>>>> Igor
>>>> 
>>>> On 12/15/2014 04:15 PM, Pavel Chistyakov wrote:
>>>>> Hi,
>>>>> 
>>>>> please take a look into slightly updated webrev:
>>>>> http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.02/
>>>>> <http://cr.openjdk.java.net/%7Eiignatyev/pchistyakov/8059551/webrev.02/>
>>>>> 
>>>>> --------------
>>>>> Thanks,
>>>>> Pavel
>>>>> 
>>>>> On 12.12.2014 23:05, Vladimir Kozlov wrote:
>>>>>> Looks fine.
>>>>>> 
>>>>>> Thanks,
>>>>>> Vladimir
>>>>>> 
>>>>>> On 12/12/14 6:07 AM, David Chase wrote:
>>>>>>> 
>>>>>>> On 2014-12-12, at 5:14 AM, Pavel Chistyakov
>>>>>>> <pavel.chistyakov at oracle.com> wrote:
>>>>>>> 
>>>>>>>> David, thank you for review.
>>>>>>>> Here is updated webrev:
>>>>>>>> http://cr.openjdk.java.net/~iignatyev/pchistyakov/8059551/webrev.01
>>>>>>>> <http://cr.openjdk.java.net/%7Eiignatyev/pchistyakov/8059551/webrev.01>
>>>>>>> 
>>>>>>> That is excellent -- now we just need a real reviewer.
>>>>>>> 
>>>>>>> David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20141222/637c7673/attachment.html>