RFR(XXS): 8034775: Failing to initialize VM when running with negative value for -XX:CICompilerCount

[Igor Ignatyev]

Albert,

Thanks, looks good to me (not a Reviewer).

Igor

On 02/13/2014 03:13 PM, Albert wrote:
> Hi Igor,
>
> you are right, thanks for catching this. I've modified the output check
> such that we don't need to add -XX:-TieredCompilation.
>
> If you think we should add -XX:-TieredCompilation nevertheless, I'll do it.
> http://cr.openjdk.java.net/~anoll/8034775/webrev.01/
>
> Many thanks,
> Albert
>
> On 02/13/2014 12:02 PM, Igor Ignatyev wrote:
>> Albert,
>>
>> your test fails, if it runs on VM w/o Tiered.
>> I'd recommend to add -XX:-TieredCompilation as an arg:
>>>   34     ProcessBuilder pb =
>>> ProcessTools.createJavaProcessBuilder("-XX:-TieredCompilation
>>> -XX:CICompilerCount=-1");
>> and change the check:
>>>   37     String expectedOutput = "CICompilerCount of -1 is invalid;
>>> must be at least 1";
>> Igor
>>
>> On 02/13/2014 02:54 PM, Albert wrote:
>>> Hi,
>>>
>>> could I get reviews for this small patch?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8034775
>>> webrev: http://cr.openjdk.java.net/~anoll/8034775/webrev.00/
>>>
>>> With this patch, we check at VM startup for a reasonable minimal number
>>> of compiler
>>> threads (1 for non-tiered, and 2 for tiered). If this minimum is not
>>> reached, the VM exits.
>>>
>>> Added regression test.
>>>
>>> Many thanks,
>>> Albert
>