[9] RFR (M): 8035828: Turn on @Stable support in VM

[Christian Thalinger]

Looks good.

On Feb 28, 2014, at 4:24 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:

> Chris, John, thanks for review.
> 
> Updated webrev:
> http://cr.openjdk.java.net/~vlivanov/8035828/webrev.01/
> 
> Best regards,
> Vladimir Ivanov
> 
> On 2/28/14 12:24 AM, John Rose wrote:
>> I agree; flags should be adjustable in product builds for bug or perf analysis, hence diagnostic.
>> 
>> Otherwise, thumbs up.
>> 
>> Nice tests!
>> 
>> — John
>> 
>> On Feb 27, 2014, at 10:06 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> 
>>> Maybe both flags should be diagnostic?  At least FoldStableValues.  It’s nothing a regular customer would turn off on a daily basis but it might be helpful for diagnosing problems.
>>> 
>>> On Feb 26, 2014, at 6:25 AM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
>>> 
>>>> http://cr.openjdk.java.net/~vlivanov/8035828/webrev.00/
>>>> https://bugs.openjdk.java.net/browse/JDK-8035828
>>>> 
>>>> @Stable was added in 8 (back in September, 2013) as an experimental feature. Future JSR292 performance improvements rely on it, so it should be turned on by default.
>>>> 
>>>> Also, as part of this change, I integrate unit tests on @Stable. They were part of initial implementation [1], but were broken when the annotation was moved to java.lang.invoke and made package-private. It blocked their integration. Now they are fixed.
>>>> 
>>>> Thanks!
>>>> 
>>>> Best regards,
>>>> Vladimir Ivanov
>>>> 
>>>> [1] http://cr.openjdk.java.net/~vlivanov/8001107/webrev.04/
>>> 
>>