Outdated comments in OptoRuntime::uncommon_trap_Type()

[Krystal Mok]

Hi all,

So, yeah, when I try to log in to bugs.openjdk.java.net, it says my account
is inactive.
Could someone with an active account help me file a bug and sponsor the
change, please?

Thanks,
Kris


On Wed, Jan 8, 2014 at 8:28 AM, Krystal Mok <rednaxelafx at gmail.com> wrote:

> Hi Chris,
>
> Thanks for the reply. I thought of doing so, but I couldn't log into the
> bug system on bugs.openjdk.java.net.
> I'll try again tonight, and will look for help again if I still can't log
> in.
>
> Cheers,
> Kris
>
>
> On Tue, Jan 7, 2014 at 3:56 PM, Christian Thalinger <
> christian.thalinger at oracle.com> wrote:
>
>> Since you are a Commiter in the jdk9 project you should open a bug
>> yourself and provide a ready-to-push changeset (maybe attach it to the bug).
>>
>> On Jan 6, 2014, at 12:29 PM, Krystal Mok <rednaxelafx at gmail.com> wrote:
>>
>> Hi all,
>>
>> Ping. Would anybody take a look at this trivial issue now that JDK9 repos
>> are open?
>>
>> Thanks,
>> Kris
>>
>>
>> On Fri, Dec 13, 2013 at 11:35 AM, Krystal Mok <rednaxelafx at gmail.com>wrote:
>>
>>> Hi all,
>>>
>>> There's a bit of comment in OptoRuntime::uncommon_trap_Type():
>>>
>>>   // Symbol* name of class to be loaded
>>>   fields[TypeFunc::Parms+0] = TypeInt::INT;
>>>
>>> It had been updated from "symbolOop name of class to be loaded", but
>>> this earlier version had been outdated for quite some time. The parameter
>>> passed into the uncommon trap stub is the "trap_reason", which is an int
>>> that combines the DeoptReason and DeoptAction, instead of a symbolOop or
>>> Symbol* for the name of class to be loaded. Would anybody fix this trivial
>>> thing, please?
>>>
>>> diff -r 8beff993531a src/share/vm/opto/runtime.cpp
>>> --- a/src/share/vm/opto/runtime.cpp Thu Dec 12 18:57:38 2013 -0500
>>> +++ b/src/share/vm/opto/runtime.cpp Fri Dec 13 11:35:21 2013 -0800
>>> @@ -568,8 +568,7 @@
>>>  const TypeFunc *OptoRuntime::uncommon_trap_Type() {
>>>    // create input type (domain)
>>>    const Type **fields = TypeTuple::fields(1);
>>> -  // Symbol* name of class to be loaded
>>> -  fields[TypeFunc::Parms+0] = TypeInt::INT;
>>> +  fields[TypeFunc::Parms+0] = TypeInt::INT; // trap_reason (deopt
>>> reason and action)
>>>    const TypeTuple *domain = TypeTuple::make(TypeFunc::Parms+1, fields);
>>>
>>>    // create result type (range)
>>>
>>> Thanks,
>>> - Kris (OpenJDK ID: kmo)
>>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140108/cc54c65d/attachment.html