[9] RFR (XXS): 8026413: ScopeDesc::is_equal is declared in header file but not implemented

Christian Thalinger christian.thalinger at oracle.com
Thu Jan 9 18:04:38 PST 2014


Thanks.

On Jan 8, 2014, at 11:58 AM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:

> Okay.
> 
> Thanks,
> Vlasimir
> 
> On 1/8/14 11:56 AM, Christian Thalinger wrote:
>> 
>> On Jan 7, 2014, at 4:05 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> 
>>> Why you want to remove this one only?
>> 
>> It was reported to me and I filed a bug to not forget it.  Now I’m cleaning up all these bugs.
>> 
>>> What about Mikael's change for all unused methods?
>> 
>> Not sure if Mikael’s patch includes that one because it’s not an unused method; the method does not exist.
>> 
>>> 
>>> Does SA have something similar to this method?
>> 
>> The SA overrides equals in ScopeDesc but that’s something different in my opinion.
>> 
>>> 
>>> Thanks,
>>> Vladimir
>>> 
>>> On 1/7/14 3:34 PM, Christian Thalinger wrote:
>>>> https://bugs.openjdk.java.net/browse/JDK-8026413
>>>> http://cr.openjdk.java.net/~twisti/8026413/webrev.00
>>>> 
>>>> 8026413: ScopeDesc::is_equal is declared in header file but not implemented
>>>> Reviewed-by:
>>>> 
>>>> Remove the header declaration.
>>>> 
>> 



More information about the hotspot-compiler-dev mailing list