[8] RFR (XXS): 8022395: java.util.zip.ZipException: Not in GZIP format in JT_JDK/test/java/util/zip/GZIP tests

[Christian Thalinger]

Thank you, Vladimir and Igor.  I’m going to push this to jdk9 too.

On Jan 16, 2014, at 3:48 PM, Igor Veresov <igor.veresov at oracle.com> wrote:

> Looks fine.
> 
> igor
> 
> On Jan 16, 2014, at 1:49 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> https://bugs.openjdk.java.net/browse/JDK-8022395
>> http://cr.openjdk.java.net/~twisti/8022395/webrev.00
>> 
>> 8022395: java.util.zip.ZipException: Not in GZIP format in JT_JDK/test/java/util/zip/GZIP tests
>> Reviewed-by:
>> 
>> C1's instrinsic for java.util.zip.CRC32.update(int b) on x86 destroys the input value b but the register is not marked to be destroyed.  This can lead to a wrong value if CRC32.update is inlined.
>> 
>> The fix is to mark the LIRItem to be destroyed.  This will make C1 to insert a spill move.
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140116/9c3e05f6/attachment.html