RFR: 8031639: make dependency management (mostly) ci independent

Roland Westrelin roland.westrelin at oracle.com
Thu Jan 23 07:08:32 PST 2014


> I assume that lines 106 and 107 above are incomplete.

Yes.

> How would you compute an ident for these values and ensure the indents for each of the 3 DepValue types don’t clash with each other? Or are you relying on a Dependencies client to either be using dep_ci_object (e.g., c1 and c2) or dep_metadata and dep_jobject (e.g., Graal) and the client ensures that ident values are unique for all DepValues added to a Dependencies object?

Yes, I would be relying on the fact that it’s either c1/c2 or graal.

> Maybe you could hum a few bars on the advantages of this approach? Is it mainly about avoiding all VM_ENTRY concerns?

It tries to use the CI objects without breaking into them. Anyway, I don’t find my solution pretty either. I’d like someone else from the team to take a look at this.

Roland.


More information about the hotspot-compiler-dev mailing list