RFR(S): JDK-8032662 : test/compiler/ciReplay/TestSA.sh should report ulimit issues
Vladimir Kozlov
vladimir.kozlov at oracle.com
Fri Jan 24 08:29:07 PST 2014
Good.
Vladimir
On 1/24/14 8:05 AM, Staffan Larsen wrote:
> That sounds like a good idea.
>
> new webrev: http://cr.openjdk.java.net/~sla/8032662/webrev.01/
>
> /Staffan
>
> On 24 jan 2014, at 16:25, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
>
>> I'm not sure that all system returns 'unlimited', some of them may return '-1', so I'd prefer '$new_ulimit != "unlimited" -a $new_ulimit != "-1"' as the condition.
>>
>> In the rest, looks good.
>>
>> Igor
>>
>> On 01/24/2014 07:22 PM, Vladimir Kozlov wrote:
>>> Looks fine to me but I want Igor's opinion as well since he is the author.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 1/24/14 7:09 AM, Staffan Larsen wrote:
>>>> Please review this small fix to a test to provide additional
>>>> diagnostics on failures.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~sla/8032662/webrev.00/
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8032662
>>>>
>>>> Thanks,
>>>> /Staffan
>>>>
>
More information about the hotspot-compiler-dev
mailing list