RFR(S) 8032656: Tag the MachSpillCopies with purpose information

[Vladimir Kozlov]

+1

I also feel uncomfortable with this approach.

Thanks,
Vladimir K

On 1/28/14 2:50 AM, Vladimir Ivanov wrote:
> Niclas,
>
> Why didn't you introduce an enum instead and pass the reason to constructor? Introducing 13 subclasses just to overload
> Name() method in debug builds looks like an overkill to me.
>
> Best regards,
> Vladimir Ivanov
>
> On 1/28/14 2:07 PM, Niclas Adlertz wrote:
>> Hi all,
>>
>> When debugging or visualizing spills/splits/moves in C2 it's hard to
>> know what caused an insertion of a certain MachSpillCopy. I've made this
>> easier by creating subclasses of the MachSpillCopyNode.
>>
>> webrev: http://cr.openjdk.java.net/~adlertz/JDK-8032656/webrev00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8032656
>>
>> Kind Regards,
>> Niclas Adlertz