[9] RFR(XS): 8032642: Fix testbugs in compiler/startup/.*

[Christian Thalinger]

Yeah, that’s what I figured.  I thought I ask anyway :-)

On Jan 27, 2014, at 9:40 PM, Albert <albert.noll at oracle.com> wrote:

> Hi Christian,
> 
> thanks for looking at this patch.
> 
> The test wants to create a situation in which there is not enough free space 
> in the code cache to allocate the C1 buffer bob (CompilerThread::get_buffer_blob()).
> The buffer blob is allocated once per C1 compiler thread when the thread is 
> initialized.
> 
> Unfortunately, I do not know an alternative to trigger this state. I know, the test
> is not particularly portable and might need to be maintained over time..
> 
> Best,
> Albert
> 
> 
> On 01/27/2014 06:11 PM, Christian Thalinger wrote:
>> The changes look good but I have a question.  Is there potentially another way to test this without using:
>> -XX:ReservedCodeCacheSize=3m -XX:CICompilerCount=64
>> ?
>> 
>> On Jan 27, 2014, at 12:15 AM, Albert <albert.noll at oracle.com> wrote:
>> 
>>> Hi,
>>> 
>>> could I get reviews for these small changes?
>>> 
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8032642
>>> webrev: http://cr.openjdk.java.net/~anoll/8032642/webrev.00/
>>> 
>>> Problems: 
>>> (1) compiler/startup/SmallCodeCacheStartup.java should use "@run main/othervm" 
>>> (2) compiler/startup/StartupOutput.java should use correct @library path
>>> 
>>> Many thanks in advance,
>>> Albert
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140129/a994dfd6/attachment.html